viccis 5 hours ago

Open source? Close it and ask them resubmit a smaller one and justify the complexity of things like a DSL if they wanted it included.

For work? Close it and remind them that their AI velocity doesn't save the company time if it takes me many hours (or even days depending on the complexity of the 9k lines) to review something intended to be merged into an important service. Ask them to resubmit a smaller one and justify the complexity of things like a DSL if they wanted it included. If my boss forces me to review it, then I do so and start quietly applying for new jobs where my job isn't to spend 10x (or 100x) more time reviewing code than my coworkers did "writing" it.

  • oarsinsync 3 hours ago

    > If my boss forces me to review it, then I do so and start quietly applying for new jobs where my job isn't to spend 10x (or 100x) more time reviewing code than my coworkers did "writing" it.

    Another equally correct approach (given the circumstances of the organisation) is to get a different AISlopBot to do the review for you, so that you spend as much time reviewing as the person who submitted the PR did coding.

    • ffsm8 3 hours ago

      That only works if you're not personally responsible for the code you review, too.

      • throwup238 3 hours ago

        Just don’t give the AI agent an “approve_pr” tool. It can only comment or reject.

        • kortilla 2 hours ago

          But then what? At the end it’s still on you to approve and you have no idea what is hiding in the code.

          • jjcob 2 hours ago

            You don't approve it. You just slowly grind the submitter down with minor feedback. At some point they lose interest and after a year you can close the PR, or ask the submitter to open a new PR.

            • adastra22 2 hours ago

              I hope you don’t actually do this to people.

              • jjcob 2 hours ago

                It works best if you don't reply immediately. I recommend successively increasing the response delay. Keep it short enough to make sure that they don't start bugging you on other channels, but long enough to make sure they have time to cool down and question if the continued effort is really worth it.

                As long as the response delay increases at least geometrically, there is a finite bound to the amount of work required to deal with a pull request that you will never merge.

                • oarsinsync an hour ago

                  Tragically, when you are organisationally impaired from saying 'no', this is the only way (besides, you know, quitting and getting a new job).

                  It's absolutely soul crushing when you're motivated to do a good job, but have a few colleagues around you that have differing priorities, and aren't empowered to do the right thing, even when management agrees with you.

              • lukan 2 hours ago

                If people do this to him? How else to react?

                The context here is lots of vibe coded garbage thrown at the reviewer.

    • adastra22 2 hours ago

      Why waste anyone’s bandwidth on this? As maintainer of some open source projects, there are no circumstances in which I would accept a 9kLOC drive by contribution like this. State so and close it.

      • oarsinsync 2 hours ago

        > Why waste anyone’s bandwidth on this?

        The conditional was: If my boss forces me to review it

        > As maintainer of some open source projects, there are no circumstances in which...

        ...you would force yourself to do anything that you don't want to do. Your approach is absolutely correct for the organisational circumstances in which this might happen to you.

        There are other organisational circumstances where being the squeaky wheel, even when it's the right thing to do for the business, will be the wrong thing for you personally. It's valuable to identify when you're standing in front of a steamroller, and get out of the way.

  • krackers 4 hours ago

    > then I do so and start quietly applying

    In this job market? And where pretty much every company seems to be following the top-down push for AI-driven "velocity"?

    • viccis 4 hours ago

      That's why I would start applying instead of just quitting. There are plenty of companies that use AI responsibly or not much at all.

      • xeonmc 3 hours ago

        This is why we need a programmer union, so that coders can collectively reject reverse-centaur slopwork, like miners rejecting asbestos mines or workers refusing to fix dangerous machines while it’s running.

        • SecondHandTofu 41 minutes ago

          More political arguments about the other effects of unions aside - I've never heard a good answer for why unions are good for workers in professions with wide ranges of skill and impact, such as lots of types of knowledge work. Do you have an answer for that?

          Roles that are more fungible, train drivers, factory workers, I can see the case from the worker's perspective, even if I think there are externalities.

          But I can't even see it from a worker's perspective in roles such as software or sales, why would anyone good want to work in an environment where much worse workers are protected, compensation is more levelised etc?

          I'm assuming this will boil down to some unspoken values differences but still thought I'd ask.

        • eru 2 hours ago

          As long as you don't pretend to talk for people who don't want to be talked for, go ahead and knock yourself out.

        • immibis 2 hours ago

          Are AI slop reviews threatening to your life?

          • zwnow 2 hours ago

            AI generated code is threatening the whole tech industry while also threatening to hurt tons of users, because people that have no business in building and deploying apps suddenly feel like they can. That Tea app was a good example for that, endangering thousands of women by leaking private conversations and address data.

            If AI slop infiltrates projects enterprises are built upon, its likely companies and their customers are metaphorically hurt too, because of a spike in outages etc... (which already happens given AWS got like 7000 outage reports after getting rid of another 14000 employees).

            Yes AI can be cool, but can we stop being this blind regarding its limitations, usecases, how its actually used, how it actually benefits humanity, and so on? Like give me a valid reason for Sora existing (except for monetizing attentionspans of humans, which I consider highly unethical).

            • kanwisher an hour ago

              Funny the app that was made to destroy other peoples lives with anonymous tips that could be fake, hurt the real perpetrators. Almost like it was karma

              • zwnow an hour ago

                Destroy other peoples lives? Wasnt it made for women to exchange about potentially dangerous men? Which there are a ton of.

            • immibis 2 hours ago

              Okay, can you avoid comparing a company going bankrupt because of a bad bet on AI, to a person getting mangled and crushed into a cube inside of an industrial machine?

              • zwnow 2 hours ago

                Where did I compare that? Getting hurt has variations. Your privacy can be hurt, your physique can be hurt, your emotions can be hurt.

        • rTX5CMRXIfFG 2 hours ago

          No. Programmer unions are going to shrink the economy and make the current job market a permanent trajectory instead of a cyclical one.

          I can’t think of why the idea of unions is gaining popularity in some programmer circles, other than that its advocates simply don’t have economic common sense.

    • nextlevelwizard 4 hours ago

      When you are applying from a job you are more desirable and you aren't desperate so you can take your pick. If your current job is bad then you can't really lose much.

      Otherwise you need to be the person at the company who cuts through the bullshit and saves it from when the VibeCodeTechDebt is popping the industry.

    • zwnow 3 hours ago

      The market only sucks for devs that lack experience or have a skillset thats oversaturated. If you only know React and Python I'm sorry, but there are like 20 million devs just like you so the one thats willing to work for the smallest coin is going to win.

throwawayffffas 8 hours ago

> How would you go about reviewing a PR like this?

Depends on the context. Is this from:

1. A colleague in your workplace. You go "Hey ____, That's kind of a big PR, I am not sure I can review this in a reasonable time frame can you split it up to more manageable pieces? PS: Do we really need a DSL for this?"

2. A new contributor to your open source project. You go "Hey ____, Thanks for your interest in helping us develop X. Unfortunately we don't have the resources to go over such a large PR. If you are still interested in helping please consider taking a swing at one of our existing issues that can be found here."

3. A contributor you already know. You go "Hey I can't review this ___, its just too long. Can we break it up to smaller parts?"

Regardless of the situation be honest, and point out you just can't review that long a PR.

  • MartijnHols 2 hours ago

    Telling a new contributor no thank you is hard. Open source contributors are hard to come by, and so I’ve always dealt with PRs like this (albeit before AI days but from people who had never written a line of code before their PR) by leaving a message that it’s a huge PR so it’s going to take a while to review it and a request to make smaller PRs in the future. A couple of times I ended up leaving over a hundred review comments, but most times they were all fixed and the contributor stuck around with many better PRs later.

    • throwawayffffas 13 minutes ago

      > Telling a new contributor no thank you is hard.

      In life in general having the wherewithal to say no is a superpower. While I appreciate the concern about alienating newcomers, you don't start contributing to an existing project by adding 9k lines of the features you care about. I have not run any open source projects that accept external contributions, but my understanding in general is that you need to demonstrate that you will stick around before being trusted with just adding large features. All code is technical debt, you can't just take on every drive by pull request in hopes they will come back to fix it when it brakes a year down the line.

    • eru 2 hours ago

      Git is flexible enough that you can tell people to break up their PR. They don't have to redo all their work.

      If you want to be really nice, you can even give them help in breaking up their PR.

      • Cthulhu_ 40 minutes ago

        Yeah exactly, the OP describes a completely new service built start to finish all in one merge request, where normally you'd start with a proposal and work from there.

jonchurch_ 8 hours ago

We are seeing a lot more drive by PRs in well known open source projects lately. Here is how I responded to a 1k line PR most recently before closing and locking. For context, it was (IMO) a well intentioned PR. It purported to implement a grab bag of perf improvements, caching of various code paths, and a clustering feature

Edit: left out that the user got flamed by non contributors for their apparently AI generated PR and description (rude), in defense of which they did say they were using several AI tools to drive the work. :

We have a performance working group which is the venue for discussing perf based work. Some of your ideas have come up in that venue, please go make issues there to discuss your ideas

my 2 cents on AI output: these tools are very useful, please wield them in such a way that it respects the time of the human who will be reading your output. This is the longest PR description I have ever read and it does not sound like a human wrote it, nor does it sound like a PR description. The PR also does multiple unrelated things in a single 1k line changeset, which is a nonstarter without prior discussion.

I don't doubt your intention is pure, ty for wanting to contribute.

There are norms in open source which are hard to learn from the outside, idk how to fix that, but your efforts here deviate far enough from them in what I assume is naivety that it looks like spam.

  • jonchurch_ 8 hours ago

    Daniel Stenberg of curl gave a talk about some of what theyve been experiencing, mostly on the security beg bounty side. A bit hyperbolic, and his opinion is clear from the title, but I think a lot of maintainers feel similarly.

    “AI Slop attacks on the curl project” https://youtu.be/6n2eDcRjSsk

fhd2 13 minutes ago

I'd say you have three options:

1. Reject it on the grounds of being too large to meaningfully review. Whether they used AI or not, this is effectively asking them to start over in an iterative process where you review every version of the thing and get to keep complexity in check. You'll need the right power and/or standing for this to be a reasonable option. At many organisations, you'd get into trouble for it as "blocking progress". If the people that pay you don't value reliability or maintainability, and you couldn't convince them that they should, that's a tough one, but it is how it is.

2. Actually review it in good faith: Takes a ton of time for large, over engineered changes, but as the reviewer, it is usually your job to understand the code and take on responsibility for it. You could propose to help out by addressing any issues you find yourself rather than making them do it, they might like that. This feels like a compromise, but you could still be seen as the person "blocking progress", despite, from my perspective, biting the bullet here.

3. Accept it without understanding it. For this you could _test_ it and give feedback on the behaviour, but you'd ignore the architecture, maintainability etc. You could still collaboratively improve it after it goes live. I've seen this happen to big (non-AI generated) PRs a lot. It's not always a bad thing. It might not be good code, but it could well be good business regardless.

Now, however you resolve it, it seems like this won't be the last time you'll struggle to work with that person. Can, and do they want to, change? Do you want to change? If you can't answer either of these questions with a yes, you'll probably want to look for ways of not working with them going forward.

yodsanklai 4 days ago

You review it like it wasn't AI generated. That is: ask author to split it in reviewable blocks. Or if you don't have an obligation to review it, you leave it there.

  • resonious 8 hours ago

    This is it. The fact that the PR was vibe coded isn't the problem, and doesn't need to influence the way you handle it.

    • gdulli 6 hours ago

      It would be willfully ignorant to pretend that there's not an explosion of a novel and specific kind of stupidity, and to not handle it with due specificity.

      • WalterSear 5 hours ago

        I contend that, by far and away the biggest difference between entirely human-generated slop and AI-assisted stupidity is the irrational reaction that some people have to AI-assisted stuff.

        • JoshTriplett 2 hours ago

          Many of the people who submit 9000-line AI-generated PRs today would, for the most part, not have submitted PRs at all before, or would not have made something that passes CI, or would not have built something that looks sufficiently plausible to make people spend time reviewing it.

          • WalterSear 2 hours ago

            9000-line PRs were never a good idea, have only been sufficiently plausible because we were forced to accept bad PR review practices. Coding was expensive and management beat us into LGTMing them into the codebase to keep the features churning.

            Those days are gone. Coding is cheap. The same LLMs that enable people to submit 9000 line PRs of chaos can be used to quickly turn them into more sensible work. If they genuinely can't do a better job, rejecting the PR is still the right response. Just push back.

        • hatefulmoron 5 hours ago

          Calling things "slop" is just begging the question. The real differentiating factor is that, in the past, "human-generated slop" at least took effort to produce. Perhaps, in the process of producing it, the human notices what's happening and reconsiders (or even better, improves it such that it's no longer "slop".) Claude has no such inhibitions. So, when you look at a big bunch of code that you haven't read yet, are you more or less confident when you find out an LLM wrote it?

          • WalterSear 4 hours ago

            I have pretty much the same amount of confidence when I receive AI generated or non-AI generated code to review: my confidence is based on the person guiding the LLM, and their ability to that.

            Much more so than before, I'll comfortably reject a PR that is hard to follow, for any reason, including size. IMHO, the biggest change that LLMs have brought to the table is that clean code and refactoring are no longer expensive, and should no longer be bargained for, neglected or given the lip service that they have received throughout most of my career. Test suites and documentation, too.

            (Given the nature of working with LLMs, I also suspect that clean, idiomatic code is more important than ever, since LLMs have presumably been trained on that, but this is just a personal superstition, that is probably increasingly false, but also feels harmless)

            The only time I think it is appropriate to land a large amount of code at once is if it is a single act of entirely brain dead refactoring, doing nothing new, such as renaming a single variable across an entire codebase, or moving/breaking/consolidating a single module or file. And there better be tests. Otherwise, get an LLM to break things up and make things easier for me to understand, for crying out loud: there are precious few reasons left not to make reviewing PRs as easy as possible.

            So, I posit that the emotional reaction from certain audiences is still the largest, most exhausting difference.

            • grey-area 4 hours ago

              clean code and refactoring are no longer expensive

              Are you contending that LLMs produce clean code?

              • WalterSear 4 hours ago

                They do, for many people. Perhaps you need to change your approach.

                • dmurray 3 hours ago

                  If you can produce a clean design, the LLM can write the code.

                  • WalterSear an hour ago

                    I think maybe there's another step too - breaking the design up into small enough peices that the LLM can follow it, and you can understand the output.

                  • fragmede 2 hours ago

                    Unless you're doing something fabulously unique (at which point I'm jealous you get to work on such a thing), they're pretty good at cribbing the design of things if it's something that's been well documented online (canonically, a CRUD SaaS app, with minor UI modification to support your chosen niche).

                    • WalterSear 2 hours ago

                      And if you are doing something fabulously unique, the LLM can still write all the code around it, likely help with many of the components, give you at least a first pass at tests, and enable rapid, meaningful refactors after each feature PR.

            • hatefulmoron 2 hours ago

              I don't really understand your point. It reads like you're saying "I like good code, it doesn't matter if it comes from a person or an LLM. If a person is good at using an LLM, it's fine." Sure, but the problem people have with LLMs is their _propensity_ to create slop in comparison to humans. Dismissing other people's observations as purely an emotional reaction just makes it seem like you haven't carefully thought about other people's experiences.

              • WalterSear an hour ago

                My point is that, if I can do it right, others can too. If someone's LLM is outputing slop, they are obviously doing something different: I'm using the same LLMs.

                All the LLM hate here isn't observation, it's sour grapes. Complaining about slop and poor code quality outputs is confessing that you haven't taken the time to understand what is reasonable to ask for, aren't educating your junior engineers how to interact with LLMs.

          • fragmede 2 hours ago

            If you try and one shot it, sure, but if you question Claude, point out the errors of its ways, tell it to refactor and ultrathink, point out that two things have similar functionality and could be merged. It can write unhinged code with duplicate unused variable definitions that don't work, and it'll fix it up if you call it out, or you can just do it yourself. (cue questions of if, in that case, it would just be faster to do it yourself.)

            • hatefulmoron 2 hours ago

              I have a Claude max subscription. When I think of bad Claude code, I'm not thinking about unused variable definitions. I'm thinking about the times you turn on ultrathink, allow it to access tools and negotiate it's solution, and it still churns out an over complicated yet partially correct solution that breaks. I totally trust Claude to fix linting errors.

              • WalterSear 2 hours ago

                If you are getting garbage out, you are asking it for too much at once. Don't ask for solutions - ask for implementations.

                • hatefulmoron 2 hours ago

                  Distinction without a difference. I'm talking about its output being insufficient, whatever word you want to use for output.

                  • WalterSear an hour ago

                    And I'm arguing that if the output wasn't sufficient, neither was your input.

                    You could also be asking for too much in one go, though that's becoming less and less of a problem as LLMs improve.

                    • hatefulmoron 37 minutes ago

                      You're proposing a truism: if you don't get a good result, it's either because your query is bad or because the LLM isn't good enough to provide a good result.

                      Yes, that is how this works. I'm talking about the case where you're providing a good query and getting poor results. Claiming that this can be solved by more LLM conversations and ultrathink is cope.

              • fragmede 2 hours ago

                It's hard to really discuss in the abstract though. Why was the generared code overly complicated? (I mean, I believe you when you say it was, but it doesn't leave much room for discussion). Similarly, what's partially correct about it? How many additional prompts does it take before you a) use it as a starting point b) use it because it works c) don't use any of it, just throw it away d) post about why it was lousy to all of the Internet reachable from your local ASN.

                • hatefulmoron an hour ago

                  I've read your questions a few times and I'm a bit perplexed. What kind of answers are you expecting me to give you here? Surely if you use Claude Code or other tools you'd know that the answers are so varying and situation specific it's not really possible for me to give you solid answers.

        • exe34 3 hours ago

          Are you quite sure that's the only difference you can think of? Let me give you a hint: is there any difference in the volume for the same cost at all?

      • rablackburn 5 hours ago

        > It would be willfully ignorant to pretend that there's not an explosion of a novel and specific kind of stupidity

        I 100% know what you mean, and largely agree, but you should check out the guidelines, specifically:

        > Don't be curmudgeonly. Thoughtful criticism is fine, but please don't be rigidly or generically negative.

        And like, the problem _is_ *bad*. A fun, on-going issue at work is trying to coordinate with a QA team who believe chatgpt can write css selectors for HTML elements that are not yet written.

        That same QA team deeply care about the spirit of their work, and are motivated by, the _very_ relatable sentiment of, you DONT FUCKING BREAK USER SPACE.

        Yeah, in the unbridled, chaotic, raging plasma that is our zeitgeist at the moment, I'm lucky enough to have people dedicating a significant portion of their life to trying to do quality assurance in the idiomatic, industry best-standard way. Blame the FUD, not my team.

        I would put to you that the observation that they do not (yet) grok what, for lack of a more specific universally understood term we are calling, "AI" (or LLMs if you are Fancy. But of course none of these labels are quite right). People need time to observe, and learn. And people are busy with /* gestures around vaguely at everything /*.

        So yes, we should acknowledge that long-winded trash PRs from AI are a new emergent problem, and yes, if we study the specific problem more closely we will almost certainly find ever more optimal approaches.

        Writing off the issue as "stupidity" is mean. In both senses.

    • cespare 5 hours ago

      It is 1995. You get an unsolicited email with a dubious business offer. Upon reflection, you decide it's not worth consideration and delete it. No need to wonder how it was sent to you; that doesn't need to influence the way you handle it.

      No. We need spam filters for this stuff. If it isn't obvious to you yet, it will be soon. (Or else you're one of the spammers.)

      • baq 2 hours ago

        Didn’t even hit the barn, sorry. Codegen tools were obvious, review assistance tools are very lagging, but will come.

  • gpm 8 hours ago

    Eh, ask the author to split it in reviewable blocks if you think there's a chance you actually want a version of the code. More likely if it's introducing tons of complexity to a conceptually simple service you just outright reject it on that basis.

    Possibly you reject it with "this seems more suitable for a fork than a contribution to the existing project". After all there's probably at least some reason they want all that complexity and you don't.

  • ashdksnndck 4 hours ago

    If you ask them to break it into blocks, are they not going to submit 10 more AI-generated PRs (each having its own paragraphs of description and comment spam), which you then have to wade through. Why sink even more time into it?

    • Buttons840 3 hours ago

      Being AI-generated is not the problem. Being AI-generated and not understandable is the problem. If they find a way to make the AI-generated code understandable, mission accomplished.

      • ashdksnndck 3 hours ago

        How much of their time should open source maintainers sink into this didactic exercise? Maybe someone should vibe-code a bot to manage the process automatically.

    • mrweasel 17 minutes ago

      There's probably also a decent chance that the author can't actually do it.

      Let's say it's the 9000 lines of code. I'm also not reviewing 900 lines, so it would need to be more than 10 PRs. The code needs to be broken down into useful components, that requires the author to think about design. In this case you'd probably have the DSL parser as a few PRs. If you do it like that it's easier for the reviewer to ask "Why are you doing a DSL?" I feel like in this case the author would struggle to justify the choice and be forced to reconsider their design.

      It's not just chopping the existing 9000 lines into X number of bits. It's submitting PRs that makes sense as standalone patches. Submitting 9000 lines in one go tells me that you're a very junior developer and that you need guidance in terms of design and processes.

      For open source I think it's fine to simply close the PR without any review and say: Break this down, if you want me to look at it. Then if a smaller PR comes in, it's easier to assess if you even want the code. But if you're the kind of person that don't think twice about submitting 9000 lines of code, I don't think you're capable of breaking down you patch into sensible sub-components.

  • userbinator 5 hours ago

    If you try to inspect and question such code, you will usually quickly run into that realisation that the "author" has basically no idea what the code even does.

    "review it like it wasn't AI generated" only applies if you can't tell, which wouldn't be relevant to the original question that assumes it was instantly recognisable as AI slop.

    If you use AI and I can't tell you did, then you're using it effectively.

    • ahtihn 4 hours ago

      If it's objectively bad code, it should be easy enough to point out specifics.

      After pointing out 2-3 things, you can just say that the quality seems too low and to come back once it meets standards. Which can include PR size for good measure.

      If the author can't explain what the code does, make an explicit standard that PR authors must be able to explain their code.

  • ivanjermakov 3 hours ago

    My record is 45 comments on a single review. Merge conditions were configured so that every comment must be resolved.

    If PR author can satisfy it - I'm fine with it.

    • cryptonym 2 hours ago

      They will let AI somewhat satisfying it and ask you for further review

  • danenania 5 hours ago

    I’m curious how people would suggest dealing with large self-contained features that can’t be merged to main until they are production-ready, and therefore might become quite large prior to a PR.

    While it would be nice to ship this kind of thing in smaller iterative units, that doesn’t always make sense from a product perspective. Sometimes version 0 has bunch of requirements that are non-negotiable and simply need a lot of code to implement. Do you just ask for periodic reviews of the branch along the way?

    • arachnid92 5 hours ago

      The way we do it where I work (large company in the cloud/cybersecurity/cdn space):

      - Chains of manageable, self-contained PRs each implementing a limited scope of functionality. “Manageable” in this context means at most a handful of commits, and probably no more than a few hundred lines of code (probably less than a hundred tbh).

      - The main branch holds the latest version of the code, but that doesn’t mean it’s deployed to production as-is. Releases are regularly cut from stable points of this branch.

      - The full “product” or feature is disabled by a false-by-default flag until it’s ready for production.

      - Enablement in production is performed in small batches, rolling back to disabled if anything breaks.

    • wiseowise 2 hours ago

      > I’m curious how people would suggest dealing with large self-contained features that can’t be merged to main until they are production-ready

      Are you hiding them from CIA or Al-Qaeda?

      Feature toggles, or just plain Boolean flag are not rocket science.

    • JonChesterfield 4 hours ago

      They come from people who have established that their work is worth the time to review and that they'll have put it together competently.

      If it's a newcomer to the project, a large self contained review is more likely to contain malware than benefits. View with suspicion.

    • foxglacier 5 hours ago

      The partial implementation could be turned off with a feature flag until it's complete.

    • exe34 3 hours ago

      you line up 10-20 PRs and merge them in a temporary integration branch that gets tested/demoed. The PRs still have to be reviewed/accepted and merged into main separately. You can say 'the purpose of this pr is to do x for blah, see top level ticket'. often there will be more than one ticket based on how self-contained the PRs are.

grodriguez100 2 hours ago

Don’t. I would refuse to review a PR with 9000 LOC and 63 new files even if written by a human. Something that large needs to be discussed first to agree on an architecture and general approach, then split in manageable pieces and merged piece-wise in a feature branch, with each individual PR having reasonable test coverage, and finally the feature branch merged into master.

Cthulhu_ 42 minutes ago

I wouldn't, they can start by writing requirements and a design first, then break it up into manageable components.

Or just refuse to review and let the author take full responsibility in running and maintaining the thing, if that's possible. A PR is asking someone else to share responsibility in the thing.

EagnaIonat 5 hours ago

Everyone talking about having them break it down into smaller chunk. Vibe coding there is a near guarantee the person doesn't know what the code does either.

That alone should be the reason to block it. But LLM generated code is not protected by law, and by extension you can damage your code base.

My company does not allow LLM generated code into anything that is their IP. Generic stuff outside of IP is fine, but every piece has to flagged that it is created by an LLM.

In short, these are just the next evolution of low quality PRs.

  • smsm42 3 hours ago

    > Vibe coding there is a near guarantee the person doesn't know what the code does either.

    Accepting code into the project when only one person (the author) knows what it does is a very bad idea. That's why reviews exist. Accepting code that zero persons know what it does is sheer screaming insanity.

  • jeroenhd an hour ago

    > Vibe coding there is a near guarantee the person doesn't know what the code does either.

    Having spent some time vibe coding over the weekend to try it out, I disagree. I understand every line of code the super-specific Android app I generated does, even if I don't have the Android dev experience to come up with the code from the top of my head. Laziness is as good a reason to vibe code as inexperience or incompetence.

    I wouldn't throw LLM code at a project like this, though, especially not in a PR of this size.

  • exe34 3 hours ago

    > Everyone talking about having them break it down into smaller chunk. Vibe coding there is a near guarantee the person doesn't know what the code does either.

    that's the point though, if they can't do it, then you close the ticket and tell them to fork off.

    • EagnaIonat 3 hours ago

      I agree, but you are potentially opening yourself up to 20+ PRs which are all vibe coded.

      • scott_w an hour ago

        Copy and paste is your friend here. If there's 20+ huge PRs, just paste "This PR is far too large to review, please break it down and submit smaller PRs and engage with us ahead of time to understand how to solve this problem."

        Comment & Close PR, only engage in discussions on tickets or smaller, understandable PRs.

        As other have said: if someone drive-by opens a huge PR, it's as likely to be malware as a beneficial implementation.

onion2k 40 minutes ago

How would you go about reviewing a PR like this?

AI is red herring in discussions like this. How the change was authored makes no difference here.

I wouldn't. I'd reject it. I'd reject it even if the author had lovingly crafted each line by hand. A change request is not "someone must check my work". It's a collaboration between an author and a reviewer. If the author is failing to bother respecting the reviewer's time then they don't deserve to get a review.

MikeNotThePope 8 hours ago

How about this?

“This PR is really long and I’m having a hard time finding the energy to review it all. My brains gets full before I get to the end. Does it need to be this long?”

Force them to make a case for it. Then see how they respond. I’d say good answers could include:

- “I really trieeld to make it smaller, but I couldn’t think of a way, here’s why…”

- “Now that I think about it, 95% of this code could be pushed into a separate library.”

- “To be honest, I vibe coded this and I don’t understand all of it. When I try to make it smaller, I can’t find a way. Can we go through it together?”

fifilura 13 minutes ago

Is it Java/Spring? Then probably go along and be happy that a human didn't have to write those 9000 lines for a trivial service.

bluerooibos 2 hours ago

I wouldn't review it - bad engineering practice to submit this much work in one go - it puts too much expectation on the reviewer and makes it more likely that something gets broken.

Even 1000 lines is pushing it, IMO. Tell them to split the PR up into more granular work if they want it merged.

sanskarix 21 minutes ago

the real problem isn't the AI - it's that someone thought you could ship meaningful work without understanding it first.

I've noticed teams getting obsessed with velocity metrics while quality tanks. pushing 9000 lines feels productive until you realize nobody can maintain it six months later when the person who vibe-coded it is gone.

here's what actually works: if they can't explain what the code does in plain english before they write it, the PR shouldn't exist. AI should speed up implementation, not replace thinking. the moment you accept code nobody understands, you've turned your codebase into technical roulette.

TriangleEdge 8 hours ago

Amazon eng did some research and found the number of comments in a code review is proportional to the number of lines changed. Huge CRs get little comments. Small CRs get a lot of comments. At Amazon, it's common to have a 150 to 300 line limit to changes. It depends on the team.

In your case, I'd just reject it and ensure repo merges require your approval.

  • kwk1 6 hours ago

    "Inversely proportional" for what it's worth

  • senderista 5 hours ago

    Also, some teams have CR metrics that can be referenced for performance evaluations.

  • zukzuk 8 hours ago

    That’s a great way to discourage anyone ever doing any large scale refactoring, or any other heavy lifting.

    • febusravenga 4 hours ago

      That's good. Because large refactorings are usually harmful. They are also usually unplanned, not scoped and based on very unquantifiable observations like "I don't like the code is structured" - let's do ity way.

    • arachnid92 5 hours ago

      Just split up your work across multiple PRs.

alexdowad 8 hours ago

Be tactful and kind, but straightforward about what you can't/don't want to spend time reviewing.

"Thanks for the effort, but my time and energy is limited and I can't practically review this much code, so I'm closing this PR. We are interested in performance improvements, so you are welcome to pick out your #1 best idea for performance improvement, discuss it with the maintainers via ..., and then (possibly) open a focused PR which implements that improvement only."

  • ivanjermakov 3 hours ago

    Depends on context of course, but in my book "my time and energy is limited" is not a valid reason for a reject. Get back once you have time, review in chunks.

    • alexdowad an hour ago

      ivanjermakov, I don't know if you are an open source maintainer or not (I am, for several projects). If you are, and you follow the policy that "I will never reject PRs because of having no time, I will always get to it eventually", then I salute you. That is a self-sacrificing, altruistic position to take. It's also a very difficult position to maintain for the long term. If you can do it: congratulations!

      As for me, my position is: "My project is my house. You want to be a guest in my house, you follow my rules. I really like people and am usually happy to answer questions from people who are reasonably polite, to review and provide feedback on their PRs, and so on. But I won't be pressured to prioritize your GitHub issue or PR over my work, my family, my friends, my health, or my personal goals in life. If you try to force me, I'll block you and there will be no further interaction."

      If you don't like that position, well, I understand your feelings.

    • wiseowise 2 hours ago

      > is not a valid reason for a reject

      As a reviewer or as a submitter?

phendrenad2 38 minutes ago

Are they truly vibe-coded? Or is the person simply accomplishing months of work in one day? Do you think the submitter reviewed it themselves? There's a difference you know. Like it or not, AI coding is not going away.

In your case, 9000 LOC and 63 files isn't that crazy for a DSL. Does the DSL serve a purpose? Or is it just someone's feature fever dream to put your project on their resume?

rhubarbtree 3 hours ago

In our company, you would immediately reject the PR based on size. There are a bunch of other quick bounce items it could also fail on, eg documentation.

The PR would then be split into small ones up to 400 lines long.

In truth, such a big PR is an indicator that either (a) the original code is a complete mess and needs reengineering or more likely (b) the PR is vibe coded and is making lots of very poor engineering decisions and goes in the bin.

We don’t use AI agents for coding. They’re not ready. Autocomplete is fine. Agents don’t reason like engineers, they make crap PRs.

  • ethin 2 hours ago

    This! And vibe-coded solutions usually will implement stuff your project already has in it, instead of reusing what already exists. Or Claude will massively over-engineer something that could be collapsed to 30 lines or something.

JohnFen 6 days ago

I'd just reject it for being ridiculous. It didn't pass the first step of the review process: the sniff test.

  • brudgers 6 days ago

    Charitably, even though it is not what you or I would do, the pull request could be a best good faith effort of a real human being.

    So to me, it's less about being ridiculous (and "ridiculous" is a fighting word) and more a simple "that's not how this team does things because we don't have the resources to work that way."

    Mildly hurt feelings in the most likely worst case (no food for a viral overtop tweet). At best recruitment of someone with cultural fit.

    • JohnFen 6 days ago

      My objection to a PR like this has nothing to do with whether or not a human wrote it. It's that the PR is too large and complex. The reason I'd give for rejecting it would be that. I wouldn't say "it's ridiculous" as the reason. I would 100% be thinking that, though.

      • brudgers 6 days ago

        That’s good.

        My experience is “too large/complex” provides an opening for arguementivenes and/or drama.

        “We don’t do it like this” does not so much. It is social, sufficient and not a matter of opinion (“too” is a matter of opinion).

        • BrenBarn 5 hours ago

          What about "this is large and complex enough to be not the way we do things"?

andreygrehov 5 hours ago

That 10+ years old joke never gets old:

10 lines of code = 10 issues.

500 lines of code = "looks fine."

Code reviews.

dustingetz 9 minutes ago

zoom call

ask them to walk you through it

ask for design doc if appropriate

what is test plan who is responsible for prod delivery and support

(no difference from any other large pr)

CharlieDigital a day ago

Ask the submitter to review and leave their comments first or do a peer code review with them and force them to read the code. It's probably the first time they'll have read the code as well...

  • groguzt 5 hours ago

    I really like this, the fact that vibe coded PRs are often bad is that people don't review it themselves first, they just look at the form, and if it looks vaguely similar to what they had in their mind, they'll just hit save and not ask the LLM for corrections

LaFolle 3 hours ago

There are good suggestions in the thread.

One suggestion that possibly is not covered is that you/we can document clearly how AI generated PRs will be handled, make it easy for contributors to discover it and if/when such PR shows up refer the documented section to save yourself time.

ivankahl 2 hours ago

What are your organization's expectations or policies regarding PR size and acceptable AI usage? Even if your organization hasn't set any expectations, what are yours—and have you communicated them to the author?

If expectations have been shared and these changes contradict them, you can quickly close the PR, explain why it's not acceptable, and ask them to redo it.

If you don't have clear guidelines on AI usage or haven't shared your expectations, you'll need to review the PR more carefully. First, verify whether your assumption that it’s a simple service is accurate (although from your description, it sounds like it is). If it is, talk to the author and point out that it's more complicated than necessary. You can also ask if they used AI and warn them about the complexities it can introduce.

O-stevns 3 hours ago

That's a lot of code for a PR, though i should admit I have made PR's being half that size myself.

Personally I think it's difficult to address these kinds of PR's but I also think that git is terrible at providing solutions to this problem.

The concept of stacked PR's are fine up to the point where you need to make changes throughout all yours branches, then it becomes a mess. If you (like me) might have a tendency to rewrite your solution several times before ending up with the final result, then having to split this into several PR's does not help anyone. The first PR will likely be outdated the moment I begin working on the next.

Open source is also more difficult in this case because contrary to working for a company with a schedule, deadlines etc... you can't (well you shouldn't) rush a review when it's on your own time. As such PR's can sit for weeks or months without being addressed. When you eventually need to reply to comments about how, why etc.. you have forgotten most of it and needs to read the code yourself to re-claim the reasoning. At that time it might be easier to re-read a 9000 lines PR over time rather than reading 5-10 PR's with maybe meaningful descriptions and outcome where the implementation changes every time.

Also, if it's from a new contributor, I wouldn't accept such a PR, vibe coded or not.

raincole 5 hours ago

You ask questions. Literally anything, like asking them why they believe this feature is needed, what their code does, why they made a DSL parser, etc.

The question itself doesn't matter. Just ask something. If their answer is genuine and making sense you deal with it like a normal PR. If their answer is LLM-generated too then block.

dosinga 8 hours ago

Ideally you have a document in place saying this is how we handle vibe coding, something like: if you have the AI write the first version, it is your responsibility to make it reviewable.

The you can say (and this is hard), this looks like it is vibe code and misses that first human pass we want to see in these situations (link), please review and afterwards feel free to (re)submit.

In my experience they'll go away. Or they come back with something that isn't cleaned up and you point out just one thing. Or sometimes! they actually come back with the right thing.

sanskarix an hour ago

the real issue is velocity theater. someone looks productive with huge PRs but the team's actual velocity tanks because everyone's stuck in review hell.

establish a hard LOC limit (500-800 lines max) and stick to it. no exceptions unless it's a genuine migration. this forces people to think through their changes instead of dumping everything at once.

rvrs 4 days ago

Enforce stacked PRs, reject PRs over 500-1k LoC (I'd argue even lower, but it's a hard sell)

Lapsa 34 minutes ago

strict lines of code limitation enforcement will lead to half-finished change requests and leak technological gibberish upstream to lovely business folk

smsm42 3 hours ago

The only way such a PR can be reviewed is if it's accompanied with a detailed PRD and tech design documents, and at least half of that LOC count is tests. Even then it requires a lot of interactive work from both sides. I have seen PRs third or quarter of this size that took weeks to properly review and bring to production quality. Unless there's something artificially inflating the side of it (like auto-generated files or massive test fixtures, etc.) I wouldn't ever commit to reviewing such a behemoth without a very very good reason to.

jeremyjh 8 hours ago

I'd just close it without comment. Or maybe if I'm feeling really generous I'll make a FAQ.md that gives a list of reasons why we'll close PRs without review or comment and link that in the close comments. I don't owe anyone any time on my open source projects. That said, I haven't had this issue yet.

  • tracerbulletx 8 hours ago

    That's fine for an open source project, but many many companies are mandating AI use, they're putting it in performance reviews, they're buying massive Cursor subscriptions. You'd be cast as an obstructionist to AI's god like velocity ™.

lionkor 3 hours ago

Close them and report to your boss. If your boss doesn't care, look for a new job. Once you have a new job, quit the old and cite that specific case as the reason.

fathermarz 4 hours ago

Let me ask a different question. Large refactor that ended up in a 60K line python PR because the new lead didn’t feel like merging it in until it was basically done. Even ask other devs to merge into his branch and then we would merge later.

How does one handle that with tact and not lose their minds?

  • JonChesterfield 4 hours ago

    Refuse to merge into their branch. If you have serious test coverage and the refactor doesn't change behaviour, it'll be fine.

    If you don't have test coverage, or if the "refactor" is also changing behaviour, that project is probably dead. Make sure there's a copy of the codebase from before the new lead joined so there's a damage mitigation roll back option available.

  • wiseowise 2 hours ago

    You get Leetcode subscription and start going through paths for a company that can match or exceed your salary.

fxtentacle an hour ago

„I trust you that you have proof-read this“ and then just merge. When production explodes, their name will be all over „git blame“.

siwatanejo 8 hours ago

Forget about code for a second. This all depends a lot of what goal does the PR achieve? Does it align with the goals of the project?

  • appreciatorBus 6 hours ago

    How can you tell if it aligns with the goals of the project without reviewing 9000 lines of code first?

    • ivanjermakov 3 hours ago

      PRs rarely exist in a vacuum. Usually there is a ticket/issue/context which required a code change.

    • siwatanejo 3 hours ago

      Are you kidding me? You should be able to explain from the user PoV what does the PR achieve, a new feature? a bugfix?

      That data point is waaaaaay more important than any other when considering if you should think about reviewing it or not.

      • wiseowise 2 hours ago

        Okay, it does align. What next?

devrundown 4 days ago

9000 LOC is way too long for a pull request unless there is some very special circumstance.

I would ask them to break it up into smaller chunks.

le-mark 8 hours ago

How long was this person working on it? Six months? Anything this big should’ve had some sort of design review. The worst is some junior going off and coding some garbage no one sees for a month.

  • jonchurch_ 8 hours ago

    You can churn this stuff out in about an hour these days though, seriously. Thats part of the problem, the asymmetry of time to create vs time to review.

    If I can write 8 9k line PRs everyday and open them against open source projects, even closing them let alone engaging with them in good faith is an incredible time drain vs the time investment to create them.

ares623 2 hours ago

Ask them if they reviewed the AI’s output before opening the PR. If they didn’t then ask them to at least review it first rather than having you do all the work. If they did then is a 2nd review from you really necessary? ;)

zigcBenx 6 days ago

In my opinion no PR should have so much changes. It's impossible to review such things.

The only exception is some large migration or version upgrade that required lots of files to change.

As far it goes for Vibe coded gigantic PRs It's a straight reject from me.

T_Potato 4 hours ago

I have a tangent question: How do you deal with a team that spends days nitpicking implementation, double-speak and saying. I didn't actually expect you to implement this the way I said, I was just saying it would be nice if it was like this, can you undo it. I spend 3 weeks on a code review because of the constant back and forth; and I wish oh I wish they would allow PR to be small but the rule is that the PR has to implement the full deliverable feature. And that can mean 20 files to constantly change and change and change and change. Oh and then the why did you use Lombok question that occurs even though the project uses lombok and so you are stuck defending the use of a library that's is used in the project for no random reason than to flatter the egos of the gatekeepers who say, yes this is good but I want you to name this abc instead of ab before we merge. When in context it doesn't add or remove any value, not even clarity.

  • tjansen 4 hours ago

    Generally, my stance is that I add more value by doing whatever ridiculous thing people ask me to change than waste my time arguing about it. There are some obvious exceptions, like when the suggestions don't work or make the codebase significantly worse. But other than that, I do whatever people suggest, to save my time, their time, and deliver faster. And often, once you're done with their initial suggestions, people just approve.

    This doesn't help all the time. There are those people who still keep finding things they want you to change a week after they first reviewed the code. I try to avoid including them in the code review. The alternative is to talk to your manager about making some rules, like giving reviewers only a day or two to review new code. It's easy to argue for that because those late comments really hinder productivity.

  • dbetteridge 4 hours ago

    Doesn't help you much I imagine, but the one time we had a dev like this he was fired after multiple complaints to the team lead.

johnnyanmac 8 hours ago

excuse me, 9000? If that isn't mostly codegen, including some new plugin/API, or a fresh repository I'd reject it outright. LLM's or not.

In my eyes, there really shouldn't be more than 2-3 "full" files worth of LOC for any given PR (which should aim to to address 1 task/bug each. If not, maybe 2-3 at most), and general wisdom is to aim to keep "full" files around 600 LOC each (For legacy code, this is obviously very flexible, if not infeasible. But it's a nice ideal to keep in mind).

An 1800-2000 LOC PR is already pushing what I'd want to review, but I've reviewed a few like that when laying scaffolding for a new feature. Most PR's are usually a few dozen lines in 4-5 files each, so it's far below that.

9000 just raises so many red flags. Do they know what problem they are solving? Can they explain their solution approach? Give general architectual structure to their implementation? And all that is before asking the actual PR concerns of performance, halo effects, stakeholders, etc.

locknitpicker 4 hours ago

> How would you go about reviewing a PR like this?

State the PR is too large to be reviewed, and ask the author to break it down into self-contained units.

Also, ask which functional requirements the PR is addressing.

Ask for a PR walkthrough meeting to have the PR author explain in detail to an audience what they did and what they hope to achieve.

Establish max diff size for PRs to avoid this mess.

dbgrman 8 hours ago

TBH, depends on what is being reviewed. Is it a prototype that might not see light of day and is only for proof-of-concept? Did an RFC doc precede it and reviewers are already familiar with the project? Were the authors expecting this PR? Was there a conversation before the PR was sent out? Was there any effort to have a conversation after the PR was shared? Was this even meant to be merged into main?

I'll just assume good intent first of all. Second, 9000 LOC spanning 63 lines is not necessarily an AI generated code. It could be a code mod. It could be a prolific coder. It could be a lot of codegen'd code.

Finally, the fact that someone is sending you 9000 LOC code hints that they find this OK, and this is an opportunity to align on your values. If you find it hard to review, tell them that I find it hard to review, I can't follow the narrative, its too risky, etc. etc.

Code review is almost ALWAYS an opportunity to have a conversation.

alganet 25 minutes ago

"too big, please break it into smaller self-contained PRs"

[ Close with comment ]

ethin 2 hours ago

If it's obviously AI generated and is an absurdly long PR, I'd ask them to extensively justify the complexity (especially if it does side quest-isms like this example where the AI created a DSL and stuff: why exactly is the DSL required?). If the project already implements the feature, I'd ask that they remove the re-implemented parts and use what already exists. If one of the dependencies of the project does this, I'd ask that they update the PR to use those instead of wholesale redoing it. If they respond, at all, with AI-generated responses instead of doing it themselves, or their PR description is AI generated, or it's blatantly obvious they used AI, I would immediately mentally classify the PR as an ultra low effort/quality PR until proven otherwise. Might seem harsh, but I prefer PRs from people who actually both understand the project and what the PR is trying to do. I don't mind if people use AI to assist in that understanding; I don't even mind if they use AI to help write parts of the PR. But if I can tell that it's AI generated (and completely re-implementing something that the project either has already or is in the stdlib or a dep is a very good sign of AI generated code in my experience), I'm far more inclined to dismiss it out of hand.

throwaway106382 8 hours ago

You don't.

Was your project asking for all this? No? Reject.

ugh123 3 hours ago

Are there tests written? You could start by demanding tests pass and demonstrate some kind of coverage metric.

ojr 4 hours ago

I would test if the new features work and if there is any regressions around critical business functions and merge it, if my manual tests pass.

calini 3 hours ago

Vibe merge review it using Copilot or equivalent, and then close it :)

  • cryptonym 2 hours ago

    Prompt: be over cautious on every code line, this is junior code and they can learn a lot from this PR. Generate many comments on why it shouldn't be merged as-is and make sure every corner case is covered. Be super paranoid, mistakes in the code could hurt the company or people.

    If you are lucky, they will also vibe fix it.

aryehof 5 hours ago

This is effectively a product, not a feature (or bug). Ask the submitter how you can you determine if this meets functional and non-functional requirements, to start with?

abhimanyue1998 6 hours ago

vibe review it with AI then run it on vibe production support. simple.

occz 3 hours ago

Easy, you reject it.

sshine 4 hours ago

Same standard as if they had made it themselves: a sequence of logically ordered commits.

wheelerwj 5 hours ago

The same way you review a non vibe coded pr. Whats that got to do with anything? A shit pr is a shit pr.

ZeroGravitas 2 hours ago

How you reject the first one of these, compared with the hundretth and the millionth(!) is probably going to be an interesting development over next few years.

Personally, I've felt drained dealing with small PRs fixing actual bugs by enthusiastic students new to projects in the pre-slop era.

Particularly if I felt they were doing it more to say they'd done it, rather than to help the project.

I imagine that motive might help drive an increase in this kind of thing.

tayo42 4 hours ago

You can't really review this. Rubber stamp it or reject it.

Roark66 4 hours ago

Many people gave good tips, so let me answer in general.

As someone on the "senior" side AI has been very helpful in speeding up my work. As I work with many languages, many projects I haven't touched in months and while my code is relatively simple the underlying architecture is rather complex. So where I do use AI my prompts are very detailed. Often I spot mistakes that get corrected etc. With this I still see a big speedup (at least 2x,often more). The quality is almost the same.

However, I noticed many "team leads" try to use the AI as an excuse to push too difficult tasks onto "junior" people. The situation described by the OP is what happens sometimes.

Then when I go to the person and ask for some weird thing they are doing I get "I don't know, copilot told me"...

Many times I tried to gently steer such AI users towards using it as a learning tool. "Ask it to explain to you things you don't understand" "Ask questions about why something is written this way" and so on. Not once I saw it used like this.

But this is not everyone. Some people have this skill which lets them get a lot more out of pair programming and AI. I had a couple trainees in the current team 2 years ago that were great at this. This way as "pre-AI" in this company, but when I was asked to help them they were asking various questions and 6 months later they were hired on permanent basis. Contrast this with: - "so how should I change this code"? - You give them a fragment, they go put it in verbatim and come back via teams with a screenshot of an error message...

Basically expecting you will do the task for them. Not a single question. No increased ability to do it on their own.

This is how they try to use AI as well. And it's a huge time waster.

  • randomNumber7 an hour ago

    You can lead a horse to water, but you can’t make it drink.

    Also people with that mentality had been a waste of time before AI too.

wengo314 6 days ago

reject outright. ask to split it into reasonable chain of changesets.

hsbauauvhabzb 3 hours ago

“Hey chatgpt, reject this pr for me. Be extremely verbose about the following topics:

- Large prs - vibe coding - development quality”

  • wiseowise 2 hours ago

    Finally, an advice from 10x AI engineer.

shinycode 3 hours ago

Don’t read it, approve it.

throwaway290 5 hours ago

Don't accept this PR. If it's bot generated you are not here to review it. They can find a bot to review bot generated requests.

999900000999 8 hours ago

Reject it and tell them to actually code it.

cat_plus_plus 4 hours ago

Vibe review with all the reasons it should not be merged obviously.

PeterStuer 3 hours ago

Before review ask for a rational and justification. Might be just overcomplicated AI slop, could also be someone actually went beyond the basics and realy produced something next level.

A simple email could tell the difference.

renewiltord 3 hours ago

It's basic engineering principle: you do not do work amplification. e.g. debouncing, request coalescing, back-pressure are all techniques to prevent user from making server do lots of work in response to small user effort.

As example, you have made summarization app. User is try to upload 1 TB file. What you do? Reject request.

You have made summarization app. User is try upload 1 byte file 1000 times. What you do? Reject request.

However, this is for accidental or misconfigured user. What if you have malicious user? There are many technique for this as well: hell-ban, tarpit, limp.

For hell-ban simply do not handle request. It appear to be handled but is not.

For tarpit, raise request maker difficulty. e.g. put Claude Code with Github MCP on case, give broad instructions to be very specific and request concise code and split etc. etc. then put subsequent PRs also into CC with Github MCP.

For limp, provide comment slow using machine.

Assuming you're not working with such person. If working with such person, email boss and request they be fired. For good of org, you must kill the demon.

mort96 3 hours ago

Close them.

userbinator 5 hours ago

If it's full of the typical vibe-coded nonsense that's easy to spot upon a quick-but-close inspection (unused functions, dead-end variables and paths that don't make sense, excessively verbose and inaccurate comments, etc.), I would immediately reject.

vasan 2 days ago

Just reflect upon it, see if you gave him less time to complete it. I would just have a meet with him and confront it.

anarticle 4 hours ago

No face, no case. They have to break it way down, just like at any org. In fact, I would ask for more tests than usual with a test plan/proof they passed. 9k is a little spicy, separate PRs, or an ad hoc huddle with them rubber ducking you through the code. Depends on if you care about this that much or not.

Unless you really trust them, it's up to the contributor to make their reasoning work for the target. Else, they are free to fork it if it's open source :).

I am a believer in using llm codegen as a ride along expert, but it definitely triggers my desire to over test software. I treat most codegen as the most junior coder had written it, and set up guardrails against as many things llm and I can come up with.

atoav 4 hours ago

Tell them to give you a phone call and have them explain the code to you : )

ChrisMarshallNY 8 hours ago

I write full app suites that have less than 9000 LoC. I tend toward fewer, large-ish source files, separated by functional domains.

I once had someone submit a patch (back in the SVN days), that was massive, and touched everything in my system. I applied it, and hundreds of bugs popped up.

I politely declined it, but the submitter got butthurt, anyway. He put a lot of work into it.

ninetyninenine 5 hours ago

You vibe review it. I’m actually only half kidding here.

exe34 3 hours ago

simple, ask them to break it down into smaller pieces with clear explanation of what it does and why it's needed. Then set up an AI to drag them in the dirt with pointless fixes. or just close them as won't-fix.

bmitc 8 hours ago

Reject it and request the author makes it smaller.

PRs should be under 1000 lines.

The alternative is to sit down with them and ask what they're trying to accomplish and solve the problem from that angle.

wheelerwj 5 hours ago

The same way you do a non vibe coded pr. If its a shit pr, its a shit pr.

est 3 hours ago

write another AI to hardcore review it and eventually reject it.

CamperBob2 5 hours ago

Please review this PR. Look carefully for bugs, security issues, and logical conflicts with existing code. Report 'Pass' if the PR is of sufficient quality or 'Fail' if you find any serious issues. In the latter case, generate a detailed report to pass along to the submitter.

(ctrl-v)

foxfired 8 hours ago

It's funny just today I published an article with the solution to this problem.

If they don't bother writing the code, why should you bother reading it? Use an LLM to review it, and eventually approve it. Then of course, wait for the customer to complain, and feed the complaint back to the LLM. /s

Large LLM generated PRs are not a solution. They just shift the problem to the next person in the chain.

  • throwawayffffas 8 hours ago

    How do you know they didn't bother to write it? For all we know the submitter has been quietly hammering away at this for months.

    • foxfired 8 hours ago

      The title says it is vibe-coded. By definition, it means they didn't write it.

      • throwawayffffas 8 hours ago

        But how do they know it's vibe-coded? It may have a smell to it. But the author might not know it for a fact. The fact it's vibe-coded is actually irrelevant the size of the request is the main issue.

        • foxfired 7 hours ago

          I'm not gonna make assumptions on behalf of OP, but if you have domain knowledge, you can quickly tell when a PR is vibe-coded. In a real world scenario, it would be pretty rare for someone to generate this much code in a single PR.

          And if they did in fact spend 6 months painstakingly building it, it wouldn't hurt to break it down into multiple PRs. There is just so much room for error reviewing such a giant PR.

        • sunaookami 5 hours ago

          You can recognize it by the rocket emojis in the PR description ;)

    • wiseowise 2 hours ago

      Then it would have extensive vcs history. Unless they just amend into one humongous commit.

exclipy 8 hours ago

I made a /split-commit prompt that automatically splits a megacommit into smaller commits. I've found this massively helpful for making more reviewable commits. You can either run this yourself or send this to your coworker to have them run it before asking you to re-review it.

Sometimes it doesn't split it among optimal boundaries, but it's usually good enough to help. There's probably room for improvement and extension (eg. re-splitting a branch containing many not-logical commits, moving changes between commits, merging commits, ...) – contributions welcome!

You can install it as a Claude Code plugin here: https://github.com/KevinWuWon/kww-claude-plugins (or just copy out the prompt from the repo into your agent of choice)

ako 5 hours ago

AI code generators are getting better fast, in the near future they will be able to produce good changes faster than you can review. How will you deal with it then? Most vibe coding tools can also produce smaller PR, but then you have to deal with 250+ PRs in 1 week. Is that more manageable? My guess is we need new tool, get the human out of the loop. More automated reviews, tests, etc.

  • ako 3 hours ago

    Instead of downvotes i would appreciate some insightful comments on this, as i'm currently struggling with this problem. In the last week i've vibe-code (vibe-engineered?) a typescript project with 230+ commits, 64 typescripts files, with 27k+ lines of code. Too much to actually read. Validation mostly through testing, automated test, architecture reviews (generate mermaid diagrams). I'm mostly reviewing the code structure and architecture, libraries it uses, etc. It has 600+ unit and integration tests, but even reviewing those is too much...

    • shinycode 2 hours ago

      Our problem is not coding. Our problem is knowledge. If no one reads it and no one knows how it works and that’s what the company wants because we need to ship fast then the company doesn’t understand what software is all about. Code is a language, we write stories that makes a lot of sense and has consequences. If the companies does not care that humans need to know and decide in details the story and how it’s written then let it accept the consequence of a sttastistically generated story with no human supervision. Let it trust the statistics when there will be a bug and no one knows how it works because no one read it and no one is there anymore to debug. We’ll see in the end if it’s cheaper to let the code be written and only understood by statistical algorithms. Otherwise, just work differently instead of generating thousand of loc, it’s your responsibility to review and understand no matter how long it takes.

    • smsm42 3 hours ago

      > In the last week i've vibe-code (vibe-engineered?) a typescript project with 230+ commits, 64 typescripts files, with 27k+ lines of code. Too much to actually read.

      Congratulations, you discovered that generating code is only part of software development process. If you don't understand what the code is actually doing, good luck maintaining it. If it's never reviewed, how do you know these tests even test anything? Because they say "test passed"? I can write you a script that prints "test passed" a billion times - would you believe it is a billion unit tests? If you didn't review them, you don't have tests. You have a pile of code that looks like tests. And "it takes too long to review" is not an excuse - it's like saying "it's too hard to make a car, so I just took a cardboard box, wrote FERRARI on it and sit inside it making car noises". Fine, but it's not a car. It's just pretending. If it's not properly verified, what you have is not tests, it's just pretending.